Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php8 compatibility #7

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fix php8 compatibility #7

merged 1 commit into from
Jan 3, 2025

Conversation

magnetik
Copy link
Contributor

Easy fix to have the package php 8 compatible

@magnetik
Copy link
Contributor Author

@caciobanu it looks like you are not very active anymore on github. Is there any way for you to add some external contributors as maintainer of this project ?

@caciobanu caciobanu merged commit dcd3eba into caciobanu:master Jan 3, 2025
1 check failed
@caciobanu
Copy link
Owner

caciobanu commented Jan 3, 2025

Merged. Thank you!

@caciobanu it looks like you are not very active anymore on github. Is there any way for you to add some external contributors as maintainer of this project ?

The usage of this package is on decline for quite some time but if interest picks up again I'll think about it.

@caciobanu
Copy link
Owner

@magnetik ,
Let me know if you need a new tag with this fix. If not I will create a new one when #8 is merged.

@magnetik
Copy link
Contributor Author

magnetik commented Jan 4, 2025

Awesome ! Ton of thanks. I can see why it's declining since it was not working on php8+ !

Not worry it can wait. I may come some other fix if I come across some problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants