builtins.fetchGit & builtins.fetchTree #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds builtins.fetchgit and the backing git import based on gitoxide. The implementation uses a temporary directory to clone a bare git repository in a separate thread. gitoxide does not yet have full async support for cloning ssh-based repositories, which is why a separate thread is used. builtins.fetchgit has more requirements than the Nix equivalent. rev is always required and a sha256 to check is not supported at this time. Change-Id: I035756c300bd694ab4ca4640ba941e4603925523
- Add support for Nix flake references parsing and URL handling - Most of the implementation resides in the glue module for builtins - Preserve unrecognized URL parameters when extracting known parameters - Add comprehensive tests for URL handling - Fetch eagerly, but block on results only upon evaluating thunk Change-Id: Ibc09c98c24b470fa321459c9ee32f373454dd0ad
domenkozar
force-pushed
the
builtins.fetchTree
branch
from
bcc0ba3 to
883c40d
Compare
|
I recently rebased your changes on the latest canon of snix here: I commented in the original upstream cl to see if maybe I can push to get it merged as I need the feature for my own work, so happy to help where I can. Feel free to hard reset on my branch if it looks good to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to implement
builtins.fetchTreeas it currently behaves in CppNix.