Use VirtualStudy service from public VS controller #11891
Merged
+120
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submitting dynamic virtual studies without explicitly defined sample IDs previously resulted in a NullPointerException. This behavior was incorrect, as dynamic studies are designed to derive their sample IDs dynamically from filters, not require them upfront. The issue revealed that the public VS controller was not using the appropriate VirtualStudy service. This change aligns the controller with the correct service to handle public dynamic virtual studies safely.
forus
force-pushed
the
demo_fix-sample-list-for-dynamic-virtual-studies
branch
from
9a484b6 to
6c768ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Submitting dynamic virtual studies without explicitly defined sample IDs previously resulted in a
NullPointerException. This behavior was incorrect, as dynamic studies are designed to derive their sample IDs dynamically from filters, not require them upfront.Root Cause
The issue was traced to the public Virtual Study controller, which was invoking the session service directly. That service assumed precomputed sample IDs and therefore failed for dynamic studies.
Fix
Result
Please merge the fix to the upstream version as well #11892