-
-
Notifications
You must be signed in to change notification settings - Fork 788
Add Spring AI for OQL Assistant #11749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FlorisVleugels
wants to merge
12
commits into
cBioPortal:master
Choose a base branch
from
FlorisVleugels:oql-assistant
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
reviewed
Oct 20, 2025
|
|
||
| @Validated | ||
| @RestController() | ||
| @ConditionalOnProperty(name = "spring.ai.enabled", havingValue = "true") |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if we need to set CORS restrictions somewhere for these endpoints? So only users of the website can use m
zainasir
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Spring AI dependency (for OQL Assistant)
Spring AI provides abstractions to integrate with various models
Key Changes
/api/assistantTodo
Spring AI has a built in evaluator for determining whether the the AI model has produced a hallucinated response or not (using another ai call to validate the other).
At the moment the context resource includes the instruction to add
OQL: TRUEorOQL:FALSEto the generated text (see example below), which is used by the frontend to decide whether to render the message or an error.Could be better to let the evaluator decide and change response accordingly, or have some feedback loop for n iterations until valid oql is returned or max is reached?
Example
{ "aiResponse": "TP53: DRIVER_SOMATIC_MUT != MISSENSE BRCA1: DRIVER_SOMATIC_MUT != MISSENSE EGFR: EXP > 2 MYC: EXP > 2 KRAS: MUT = (12-13) != NONSENSE OQL: TRUE" }Related PR
frontend PR that adds the OQL Assistant UI