generated from JetBrains/intellij-platform-plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP c3 function indexing and completion #9
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got this error:
|
Something also happened with function attributes. It looks like it's always expecting them...? But lookup for functions work! HORRAY! |
The above happened as I was typing "module test" |
Yeah, I have to fix PSI tree (recoverWhile), otherwise weird errors will happen. Ill keep you posted. |
Very nice already just to have that working. |
9a7cd2d
to
85290d5
Compare
Is it ready to merge now? |
Not yet. Sorry for confusion. |
374f0a3
to
6b2b9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its work in progress.
Added:
What have to be done:
Completion now works only when function is not broken from parser perspective:
@lerno
I would also add few things to this PR:
tokens=[]
into C3.bnf (from C3.flex) so I can iterate faster on error recovery.