Added .hash() functions for vectors #2043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks wrong. You're hashing the vectors on their pointer, not on their content. |
…slice, the same approch is used for arrays
|
It should be fixed now. I also added support for arrays of all the normal types. |
|
For the tests you want to create two vectors separately but with the same values and check that they give the same hash. |
|
I did do that in a test program I wrote, but since the normal hash functions did not do this I hadn't added it to the test yet. |
lerno
reviewed
Mar 20, 2025
| macro uint uint128.hash(uint128 i) => @generic_hash(i); | ||
| macro uint uint128[<*>].hash(uint128[<*>] i) => (uint)fnv32a::hash(((char*)&&i)[:$sizeof(i[0])*i.len]); |
There was a problem hiding this comment.
Please add space between operators to keep the code consistent, e.g. $sizeof(i[0]) * i.len
|
If you take the address of char/ichar arrays / vectors they can be cast to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only vectors up to 16 bytes in size can be used in a Hashmap due to the requirement of
$Type.alignof <= mem::DEFAULT_MEM_ALIGNMENTonallocator:newI recon allowing for larger types would require changes to the Hashmap module.
Suggestions on how to improve the functionalities are welcome.