-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add determinant, laplace and cross products to math_vector.c3 #2040
base: master
Are you sure you want to change the base?
Conversation
Can you please add some actual tests, look into test/unit how to construct them. You can then use |
9644ecd
to
69a9c9d
Compare
cfe8d35
to
e6158c3
Compare
Sorry, that part wasn't supposed to be there. Not that it harms anything but.. |
One question I have is whether the vector operations are the most efficient this way (I'm thinking of the 4 cross product) or not, have you measured the resulting output compared to writing it out on -O1? Also, possibly the two different windings should be two different functions instead. |
I am confused. There is this: But this looks like it's assuming
Which means it's not applicable to any float vectors that aren't len = 2. Also, it is only defined for floats, as opposed to both doubles and floats. I am also a little concerned that only some of them have tests. |
test_vec_cross
totest/unit/stdlib/math/vector_math.c3