✨ Enhancement: Add Visual Loading Spinners for Long-Running GDB Commands#128
Open
Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Open
✨ Enhancement: Add Visual Loading Spinners for Long-Running GDB Commands#128Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Enhancement: Add Visual "Loading" Spinners for Long-Running GDB Commands (#127)
This Pull Request fixes #127.
Description
Previously, when a user clicked any execution control button (Run, Reverse, Next) in the
DebugHeader, the frontend immediately fired off theaxiosrequest to the GDB backend but provided zero visual feedback. This caused users to think the application was broken, resulting in them clicking the buttons multiple times and spamming the backend with duplicate GDB directives.This PR solves the problem by introducing asynchronous UI state management during GDB executions.
Added a global
isLoadingboolean state to the rootDataContext.jsx.Wrapped the
<TerminalComp />Axios cycle withsetIsLoading(true)on initialization andsetIsLoading(false)on resolution or exception.Updated
DebugHeader.jsxto intercept clicks whenisLoading === true, effectively disabling rapid presses.Implemented a sleek, rotating
<FaSpinner />CSS animation that temporarily replaces the debug controls while the backend thinks, providing immediate, explicit feedback.Additional context
cc: @charithccmc @Ammoniya ready for review!