feat: implement global error states and toast notifications#126
Open
Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Open
feat: implement global error states and toast notifications#126Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Conversation
Author
|
This PR implements global error toasts! I elevated Could you please review and merge? @charithccmc @Ammoniya |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: implement global error states and toast notifications (#125)
This Pull Request fixes #125.
Description
Previously, when the system failed to communicate with the
gdbui_server(e.g. backend crash, misconfigured endpoint, initial loading timeouts), Axios errors within data-fetchingtry/catchblocks were silently swallowed and logged to the console. This resulted in the UI freezing with no user feedback.This UI enhancement completely solves this developer experience gap by lifting
react-toastifyinto the<App />root and plumbingtoast.errordispatchers directly into all component-level exception handlers.Extracted the local
<ToastContainer />fromBreakpoint.jsxand mounted it at the global level with proper theme propagation insideApp.jsx.Replaced the dead
console.log(error)fallback logic insideStack.jsx,Functions.jsx,TerminalComp.jsx, andDataContext.jsxwith descriptive, immediate boolean feedback viatoast.error("...")alerts.Additional context
cc: @charithccmc @Ammoniya for review!