fix: remove hardcoded placeholder function names from Functions render (#120)#121
Open
Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: remove hardcoded placeholder function names from Functions render (#120)#121Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Jayant-kernel wants to merge 1 commit intoc2siorg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove hardcoded placeholder function names from Functions render (#120)
This PR fixes #120.
Description
The
Functionscomponent previously appended 10 raw rows of hardcoded dummy data ("sub.KERNEL32.dll_DeleteCritical_231") alongside every valid result set. This polluted the UI and gave users the false impression that these were actual values fetched from their local GDB debug session context.Dropped the static
dataarray containing the repeated"sub.KERNEL32.dll_DeleteCritical_231"strings fromFunctions.jsx.Removed the mapping iteration in the render block that appended these mocks.
Additional context
The component now correctly and exclusively renders the dynamic function symbols payload passed back from the python backend via
get_locals, aligning with expected frontend behavior and leaving no leftover developer mock artifacts. No additional styling was necessary to accommodate the change.