[DO NOT MERGE] Do not avoid copying array content for const ** arrays. Do that for * consts.#777
Open
atsushieno wants to merge 1 commit intobytedeco:masterfrom
Open
[DO NOT MERGE] Do not avoid copying array content for const ** arrays. Do that for * consts.#777atsushieno wants to merge 1 commit intobytedeco:masterfrom
* consts.#777atsushieno wants to merge 1 commit intobytedeco:masterfrom
Conversation
…* const`s. This fixes bytedeco#776 Before this change, we did not copy array contents back to the argument array for "const **" as it is regarded as immutable. But it in fact it mutable. This StackOverflow question describes it well. https://stackoverflow.com/questions/4949254/const-char-const-versus-const-char After this change, it will avoid copying if the parameter pointer itself is const.
atsushieno
changed the title
* consts.* consts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #776
Before this change, we did not copy array contents back to the argument array for "const **" as it is regarded as immutable. But it in fact it mutable. This StackOverflow question describes it well.
https://stackoverflow.com/questions/4949254/const-char-const-versus-const-char
After this change, it will avoid copying if the parameter pointer itself is const.