fix: avoid shelling out for directory views#418
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #376.
This removes the shell
findcall from directory views in both text editor tool implementations. Directory listing is now done throughpathlib, so a directory name containing shell metacharacters is treated as a path instead of command text.I kept the existing behavior of listing visible items up to two levels deep and skipping hidden path components.
To verify
PYTHONPATH=. uv run --extra test --extra evaluation python -m pytest tests/tools/test_edit_tool.py -quv run ruff check trae_agent\tools\edit_tool.py trae_agent\tools\edit_tool_cli.py tests\tools\test_edit_tool.pyuv run ruff format --check trae_agent\tools\edit_tool.py trae_agent\tools\edit_tool_cli.py tests\tools\test_edit_tool.pyuv run python -m py_compile trae_agent\tools\edit_tool.py trae_agent\tools\edit_tool_cli.py tests\tools\test_edit_tool.pygit diff --check