fix(gateway): support localhost dev ports in CORS#1007
Open
stablegenius49 wants to merge 1 commit intobytedance:mainfrom
Open
fix(gateway): support localhost dev ports in CORS#1007stablegenius49 wants to merge 1 commit intobytedance:mainfrom
stablegenius49 wants to merge 1 commit intobytedance:mainfrom
Conversation
|
|
Collaborator
|
@stablegenius49 Thanks for your contribution. Please click the CLA button to sign the CLA first, and then we can review your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CORSMiddlewarein the gateway for direct backend access in local devCORS_ORIGINSparsing and add regression tests for config + middleware wiringVerification
cd backend && python3 -m py_compile src/gateway/config.py src/gateway/app.py tests/test_gateway_cors.pycd backend && pytest -q tests/test_gateway_cors.py(fails in this environment:ModuleNotFoundError: fastapi; backend deps are not installed here)Closes #47