feat(core,logging): attach location/dependency where wasm_pkg_core::wit::resolve_dependencies failed

[mkatychev]

Summary

wkg wit build currently returns an unhelpful report when path resolution fails during resolve_dependencies:

$ wkg wit build --wit-dir ./wit --config wkg-config.toml
 INFO wasm_pkg_core::lock: dependency package was not in the lock file 
    package_ref=namespace:pkg1 registry=Some("my-registry.com") requirement==0.1.0
DEBUG wasm_pkg_core::resolver: dependency already exists and override is not set, ignoring
    name=namespace:pkg1
 INFO wasm_pkg_core::lock: dependency package was resolved by the lock file
    package_ref=namespace:pkg2 registry=Some("my-registry.com") requirement==0.1.0 resolved_version=0.1.0
DEBUG wasm_pkg_core::resolver: dependency already exists and override is not set, ignoring
    name=namespace:pkg2
Error: Unable to resolve dependencies

Caused by:
    No such file or directory (os error 2)

In the case above, pkg3 was the cause of the failure with logging failing to show it.

Changes

• Added Display impl for Dependency
• resolve_dependencies now attaches paths/dependencies to the relevant anyhow::Error:

  Caused by:
      0: namespace/pkg3
      1: No such file or directory (os error 2)
  

• ran cargo clippy --fix
• ran typos ./crates --write-changes

[lann]

Mostly looks good. Some style and error message suggestions.

[lann]

Not a huge problem but the previous if/else if/else structure seems like more typical rust code.

[mkatychev]

I can revert the style, I had a hard time understanding the else if let Some(_) chains because they all did things slightly differently and it made it tricky to reason about without a consistent corollary.

Only after I broke it down did I realize it was really the same lookup for two different fields.

[mkatychev]

For code golf's sake the function could be rewritten as this:

pub fn resolve_registry(&self, package: &PackageRef) -> Option<&Registry> {
    let namespace = package.namespace();
    // look in `self.package_registry_overrides `
    // then in `self.namespace_registries`
    self.package_registry_overrides
        .get(package)
        .or_else(|| self.namespace_registries.get(namespace))
        .map(|pkg| pkg.registry())
        .or(self.default_registry.as_ref())
        .or_else(|| self.fallback_namespace_registries.get(namespace))
}

EDIT: I went with a simpler (hopefully more rusty) approach.

[lann]

Thanks for the updates