Prefer to get & set exception from exec_env_tls #4007
+48
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions are currently stored in module instance, but if most of them can be stored at the exec_env that would allow using a single module instance in parallel without locking and handle the exception separately.
Using a single module instance in parallel might not be usual, but it's possible from what I understand and tested WAMR, at least for specific use cases (e.g. no writing to globals or wasm memory, only reading from that and writing to wasm stack). Please correct me if I'm missing anything.
This PR proposes a change in how we store and retrieve exception from a given module instance: