implement local and function calls for v128 in the fast interpreter #4005
Conversation
Zzzabiyaka
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
Zzzabiyaka
force-pushed
the
makslit/load_opcodes
branch
7 times, most recently
from
38895ee to
29181b5
Compare
| @@ -3536,6 +3541,24 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module, | |||
| HANDLE_OP_END(); | |||
| } | |||
|
|
|||
| #if WASM_ENABLE_SIMDE != 0 | |||
There was a problem hiding this comment.
#if WASM_ENABLE_SIMDE != 0 this should be #if WASM_ENABLE_SIMD != 0 but I'll fix it once we make the spec tests work and are ready to launch
There was a problem hiding this comment.
I do think we might not need WASM_ENABLE_SIMDE flag in the first place, it probably should be set based on fast-interp + simd
Zzzabiyaka
force-pushed
the
makslit/load_opcodes
branch
3 times, most recently
from
84a5a0f to
f72af42
Compare
Zzzabiyaka
force-pushed
the
makslit/load_opcodes
branch
2 times, most recently
from
667c8e1 to
0e0e2d0
Compare
Zzzabiyaka
force-pushed
the
makslit/load_opcodes
branch
from
0e0e2d0 to
3562824
Compare
|
looks like the CI failure is due to github infra and not my code, I think we're merge-ready |
| @@ -3536,6 +3543,24 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module, | |||
| HANDLE_OP_END(); | |||
| } | |||
|
|
|||
| #if WASM_ENABLE_SIMDE != 0 | |||
| HANDLE_OP(EXT_OP_SET_LOCAL_FAST_V128) | |||
| HANDLE_OP(EXT_OP_TEE_LOCAL_FAST_V128) | |||
There was a problem hiding this comment.
This file already quite bloated and difficult to maintain, I wonder if you considered refactoring it a bit? E.g. both EXT_OP_TEE_LOCAL_FAST_V128 and EXT_OP_COPY_STACK_TOP_V128 are very similar for the i64 opcode implementations.
| #if WASM_ENABLE_FAST_INTERP != 0 && WASM_ENABLE_SIMDE != 0 | ||
| EXT_OP_SET_LOCAL_FAST_V128 = 0xdd, | ||
| EXT_OP_TEE_LOCAL_FAST_V128 = 0xde, | ||
| EXT_OP_COPY_STACK_TOP_V128 = 0xdf, |
There was a problem hiding this comment.
Seems that EXT_OP_COPY_STACK_TOP_V128 is unneeded? It isn't emitted in wasm_loader.c.
add fast versions of local.set/get
add additional opcodes for these operations
add v128 values to handling of function params and return values
why?
These changes allowed us to run spec tests for simd as before that, functions with v128 params / return values could not be called