add a validator for aot module #3995
Open
+92
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
requested review from
loganek,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
lum1n0us
force-pushed
the
feat/aot_validator
branch
from
3597249 to
1d47fc5
Compare
lum1n0us
force-pushed
the
feat/aot_validator
branch
from
1d47fc5 to
716fcb7
Compare
|
Maybe it's a good idea to use a macro to control the validation AOT, making users choose based on the actual scenario. By our original design, the aot file should be from a trusted source, so should we turn off validation by default? |
TianlongLiang
approved these changes
Jan 8, 2025
| @@ -117,4 +116,3 @@ aot_create_perf_map(const AOTModule *module, char *error_buf, | |||
|
|
|||
| return ret; | |||
| } | |||
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
There was a problem hiding this comment.
maybe add an empty line at the end of the file
|
It's a little odd. You can't see it, but if you open it locally or with github.dev, as in github.dev, you'll notice an empty line at the end of the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to #3986 for more details.