Add context to enlarge memory error callback #2546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Sep 13, 2023
core/iwasm/include/wasm_export.h
Outdated
|
|
||
| /** | ||
| * Setup callback invoked when memory.grow fails | ||
| */ | ||
| WASM_RUNTIME_API_EXTERN void | ||
| wasm_runtime_set_enlarge_mem_error_callback( | ||
| const enlarge_memory_error_callback_t callback); | ||
| const enlarge_memory_error_callback_t callback, void *context); |
There was a problem hiding this comment.
@eloparco How about changing the argument name to user_data? I remember we usually called data like this with user_data.
eloparco
force-pushed
the
eloparco/memory-grow-callback-context
branch
from
07dabc8 to
f09a907
Compare
wenyongh
reviewed
Sep 13, 2023
core/iwasm/include/wasm_export.h
Outdated
| @@ -1447,14 +1447,15 @@ typedef enum { | |||
| typedef void (*enlarge_memory_error_callback_t)( | |||
| uint32_t inc_page_count, uint64_t current_memory_size, | |||
| uint32_t memory_index, enlarge_memory_error_reason_t failure_reason, | |||
| wasm_module_inst_t instance, wasm_exec_env_t exec_env); | |||
| wasm_module_inst_t instance, wasm_exec_env_t exec_env, | |||
| void* context); | |||
There was a problem hiding this comment.
Had better void *user_data?
There was a problem hiding this comment.
Sorry I missed that one, fixed
eloparco
force-pushed
the
eloparco/memory-grow-callback-context
branch
from
f09a907 to
01cf290
Compare
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
g0djan
pushed a commit
to g0djan/wasm-micro-runtime
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #2522.
When trying to use the callback in practice (from an embedder), I realized that not being able to pass some context (i.e. data passed from the embedder that can be used in the callback) is quite limiting.