Closed
Conversation
This is like `epoll::wait`, except that it can read into an uninitialized buffer, and it returns a pair of slices, similar to `read_uninit`. This also means it doesn't require "alloc".
sunfishcode
force-pushed
the
sunfishcode/epoll-uninit
branch
from
d3c86be to
3360853
Compare
Member
Author
|
Closing in favor of #1290, which I'm feeling more confident in now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is like
epoll::wait, except that it can read into an uninitialized buffer, and it returns a pair of slices, similar toread_uninit. This also means it doesn't require "alloc".This is a possible alternative direction to #1290. I'm on the fence still. I like some things about the
Buffertrait magic, including how it can encapsulate the unsafety of theset_lento resize aVecto the number of initialized bytes. However, I don't like how it seems to feel more magical than it is. Inread(fd, extend(&mut v)), you still have to think about end-of-stream,EINTR, short reads, and spare capacity.