Fix: label the close-dialog draft button with the generic Save#590
Open
dealerweb wants to merge 1 commit into
Open
Fix: label the close-dialog draft button with the generic Save#590dealerweb wants to merge 1 commit into
dealerweb wants to merge 1 commit into
Conversation
"Save Draft" made the third button of the save-or-discard dialog wrap onto two lines in several languages (German "Entwurf speichern", French "Enregistrer le brouillon", ...) while its siblings stay one line. The dialog title already says the draft is what's being saved, so the button now uses the existing generic common.save key - one short word in every locale, no new translations needed. email_composer.save_draft had exactly this one consumer; the dead key is removed from all 22 locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The third button of the "Save or discard draft?" dialog wraps onto two lines in several languages, making the button row look broken next to its one-line siblings. Shortening the label fixes this at the root, in every locale at once.
Why
common.savealready exists, translated in all 22 locales, and the composer already has thecommontranslator in scope - so the fix is one changed line of code and zero new translations.whitespace-nowrap: on narrow phones that would turn the wrap into horizontal overflow. A short label degrades gracefully everywhere.Changes
common.saveinstead ofemail_composer.save_draft.email_composer.save_drafthad exactly this one consumer, so the now-dead key is removed from all 22 locales (verified programmatically: only this key removed, every other value byte-identical).Type of Change
Checklist
tsc --noEmitpasses (0 errors)eslintpasses on the changed filenext buildsucceeds (exit 0)Notes for Reviewers