Skip to content

Update Documentation and Clarify Comments in NIF and PyNode Implementations #9132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update Documentation and Clarify Comments in NIF and PyNode Implementations #9132

wants to merge 2 commits into from

Conversation

@zeevick10
Copy link

@zeevick10 zeevick10 commented Jun 15, 2025

Description:
This pull request includes the following changes:

  • Updated the documentation in the ockam_rust_elixir_nifs README to clarify that the SHA sum update applies to supported NIF architectures.
  • Improved a comment in the PyNode Rust implementation to clarify the reasoning behind the secure channel/TCP connection handling, without changing the logic.

@zeevick10 zeevick10 requested a review from a team as a code owner June 15, 2025 13:42
@mrinalwadhwa mrinalwadhwa force-pushed the develop branch 3 times, most recently from 4acf693 to 32c068e Compare November 2, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zeevick10