Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #156 - elements of length 75 being ignored #157

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

derekpa
Copy link

@derekpa derekpa commented Feb 14, 2024

Updating the comparison logic so elements of length 75 are included not just less than: if length <= 75:

@mflaxman
Copy link
Collaborator

Thanks for the PR @derekpa. Can you add some tests?

@derekpa
Copy link
Author

derekpa commented Feb 16, 2024

Hi, I added a test with the script mentioned in the bug and ran the tests again to make sure it passed.

The code without the fix failed the test as the original issue reported.

Is that OK? Should I add anything else?

@mflaxman
Copy link
Collaborator

Can you add a real bitcoin transaction that was previously failing that now parses correctly?

@derekpa
Copy link
Author

derekpa commented Feb 17, 2024

Hi, looking back at the original issue Im now not too sure if bucko13 was just reporting the potential issue for failure because of the code, or was actually coming across unparsable scripts which is what the title implies.

Do you have any examples bucko13 ?

So other than the example he gave I cant think of a more common script or example that would have an element of exactly 75.

@bucko13
Copy link

bucko13 commented Oct 22, 2024

Ooof, sorry. No idea why I missed this ping. It's been a while since I first reported this and don't have a tx offhand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants