Sync tracer refactor into pipeline and modules #502

robert-smartbear · 2025-10-29T09:12:29Z

No description provided.

Co-authored-by: Jason <[email protected]>

Co-authored-by: Robert Bartoszewski <[email protected]>

* Amend secondary instance URL to bugsnag.smartbear.com * Update define's name

Benchmarking

* BugsnagPerformanceNamedSpans optimization * Fixed span name comparison method * Switched to NSMutableDictionary * Removed unused code --------- Co-authored-by: Robert Bartoszewski <[email protected]>

Co-authored-by: Robert Bartoszewski <[email protected]>

* Separate test features into smaller files * Change name of hardcoded feature for full builds * Move automatic and metrics related features to folders

…00_tracer_refactor_lifecycle_handler # Conflicts: # Sources/BugsnagPerformance/Private/Tracer.h # Sources/BugsnagPerformance/Private/Tracer.mm

…r_lifecycle_handler Tracer refactor: SpanLifecycleHandler

…r_span_store Tracer refactor: span store

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.1 to 4.30.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@39edc49...16140ae) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.30.9 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.2 to 2.4.3. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@05b42c6...4eaacf0) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-version: 2.4.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@11bd719...08c6903) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 5.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.30.9 to 4.31.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16140ae...4e94bd1) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Steve Kirkland <[email protected]>

…#498) * Fixed spanOnDestroy causing a crash * E2E test * Updated changelog --------- Co-authored-by: Robert Bartoszewski <[email protected]>

# Conflicts: # BugsnagPerformance.xcodeproj/project.pbxproj # CHANGELOG.md # Sources/BugsnagPerformance/Private/Tracer.mm # Sources/BugsnagPerformance/Public/BugsnagPerformanceSpan.mm # features/default/automatic/automatic_view_load.feature # features/default/manual_spans.feature # features/default/metrics/metrics_cpu.feature # features/default/network.feature # features/fixtures/ios/Fixture.xcodeproj/project.pbxproj # features/fixtures/ios/FixtureXcFramework.xcodeproj/project.pbxproj # features/steps/app_steps.rb

Sync next into v2

…_into_tracer_refactor

…ctor Sync v2 into tracer refactor

… into robert/merge_tracer_refactor_into_pipeline_and_modules # Conflicts: # BugsnagPerformance.xcodeproj/project.pbxproj # Sources/BugsnagPerformance/Private/Core/Span/SpanOptions.h # Sources/BugsnagPerformance/Private/Tracer.mm # features/default/automatic/automatic_view_load.feature # features/default/initial-p-value.feature # features/default/manual_spans.feature # features/default/metrics.feature # features/default/sampling.feature

github-actions · 2025-10-29T09:13:52Z

BugsnagPerformance.framework binary size increased by 1,928 bytes from 944,440 to 946,368

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.7% +1.50Ki  +0.7% +1.50Ki    __TEXT,__text
  +0.4%   +1000  +0.4%   +1000    String Table
  +0.4%    +800  +0.4%    +800    Symbol Table
  +1.5%    +316  +1.5%    +316    __TEXT,__gcc_except_tab
  +0.4%    +152  +0.4%    +152    __DATA,__objc_const
  +0.7%    +128  +0.7%    +128    __TEXT,__objc_stubs
   +21%    +112   +21%    +112    Export Info
  +0.2%     +59  +0.2%     +59    __TEXT,__objc_methname
  +0.6%     +56  +0.6%     +56    __TEXT,__unwind_info
  +0.3%     +48  +0.3%     +48    __DATA_CONST,__const
  +0.7%     +32  +0.7%     +32    __DATA,__objc_selrefs
  +0.2%     +16  +0.2%     +16    [__DATA_CONST]
  +0.2%     +16  +0.2%     +16    __TEXT,__const
  +0.3%      +8  +0.3%      +8    Function Start Addresses
  +0.4%      +8  +0.4%      +8    Rebase Info
  [ = ]       0  +5.6%      +8    __DATA,__bss
  -0.0%      -4  -0.0%      -4    [2 Others]
  -0.7%     -64  -0.7%     -64    __DATA_CONST,__cfstring
  -9.4%    -188 -10.5%    -196    [__DATA]
  [ = ]       0 -33.1% -1.88Ki    [__LINKEDIT]
  -4.9% -2.06Ki  -4.9% -2.06Ki    [__TEXT]
  +0.2% +1.88Ki  [ = ]       0    TOTAL

Generated by 🚫 Danger

yousif-bugsnag and others added 30 commits July 28, 2025 11:57

Added basic module structure for BugsnagPerformanceNamedSpans

5ac70bd

Implemented BugsnagPerformanceNamedSpansPlugin

6d7b67b

Added BugsnagPerformanceNamedSpans to example app

9462496

Added unit tests for named spans plugin

198e6a8

Add missing import for BugsnagPerformancePriority

b997a05

Added maze runner scenario for named spans plugin

6dbcbb4

Update unit tests

f8046a2

Update min deployment target

8633b6e

Fixed .pbxproj issues

eb28e91

Added BugsnagPerformanceNamedSpansTests to the test scheme

3894030

Fixed BugsnagPerformanceNamedSpansTests

57879f2

Fixed priority symbol visibility

d99df97

Update xcframework pipeline to include named spans module

7527ed4

Add named spans module to fixture project

4c6f934

Updated unit tests

de4ab7e

Added named spans to xcframework fixture

919bf4d

Fixed xcframework fixture build script

bfdba37

Added an xcscheme for BugsnagPerformanceNamedSpans

630e9c4

Made BugsnagPerformanceNamedSpans headers public

e67d746

Created BugsnagPerformanceNamedSpans.h

6c4a003

Fixed BugsnagPerformanceNamedSpans.h

6d53fab

Fixed concurrency test

3500148

Improved span timeout handling

36dc309

Refactored plugin to allow better testing of timeout handling

9da42c8

Use std::unordered_map for span timeout timers

0209149

Co-authored-by: Jason <[email protected]>

Rename endNativeSpan method to didEndNativeSpan

a10b0df

Co-authored-by: Robert Bartoszewski <[email protected]>

Move spansByName initialisation to init method

14c7618

Remove extra line

6980667

Co-authored-by: Robert Bartoszewski <[email protected]>

Fixed zero padding of span and trace IDs in Crosstalk API

747390a

Added changelog entry

ec0a4a3

DariaKunoichi and others added 21 commits September 5, 2025 12:13

Amend secondary instance URL to bugsnag.smartbear.com (#473)

8371de3

* Amend secondary instance URL to bugsnag.smartbear.com * Update define's name

Merge pull request #476 from bugsnag/robert/plat-14716_benchmarking

636d26a

Benchmarking

BugsnagPerformanceNamedSpans optimization (#481)

0223169

* BugsnagPerformanceNamedSpans optimization * Fixed span name comparison method * Switched to NSMutableDictionary * Removed unused code --------- Co-authored-by: Robert Bartoszewski <[email protected]>

Tracer refactor: removed dead code and excessive logging (#485)

c407989

Co-authored-by: Robert Bartoszewski <[email protected]>

Separate test features into smaller files (#490)

595ae86

* Separate test features into smaller files * Change name of hardcoded feature for full builds * Move automatic and metrics related features to folders

Add tests for app start type customization (#491)

9ca71db

Merge branch 'robert/plat-14800_tracer_refactor' into robert/plat-148…

2a1a716

…00_tracer_refactor_lifecycle_handler # Conflicts: # Sources/BugsnagPerformance/Private/Tracer.h # Sources/BugsnagPerformance/Private/Tracer.mm

Merge pull request #486 from bugsnag/robert/plat-14800_tracer_refacto…

eadc3d6

…r_lifecycle_handler Tracer refactor: SpanLifecycleHandler

Merge pull request #488 from bugsnag/robert/plat-14800_tracer_refacto…

535e6a7

…r_span_store Tracer refactor: span store

Provide local implementation of moved Maze Runner function (#496)

45120a1

Co-authored-by: Steve Kirkland <[email protected]>

Calling endOnDestroy on a span causes a crash in sendCurrentBatchTask (…

207594f

…#498) * Fixed spanOnDestroy causing a crash * E2E test * Updated changelog --------- Co-authored-by: Robert Bartoszewski <[email protected]>

Merge pull request #499 from bugsnag/robert/merge_next_into_v2

54cb8f5

Sync next into v2

Merge branch 'robert/plat-14800_tracer_refactor' into robert/merge_v2…

58151b7

…_into_tracer_refactor

Merge pull request #501 from bugsnag/robert/merge_v2_into_tracer_refa…

3bef780

…ctor Sync v2 into tracer refactor

robert-smartbear requested a review from DariaKunoichi as a code owner October 29, 2025 09:12

robert-smartbear changed the base branch from next to robert/plat-14800_tracer_refactor_pipeline_and_modules October 29, 2025 09:12

Fixed Benchmarks fixture

4ea0fab

robert-smartbear force-pushed the robert/merge_tracer_refactor_into_pipeline_and_modules branch 2 times, most recently from 6de01d5 to 03478d2 Compare October 29, 2025 12:32

Fixed E2E tests

96efead

robert-smartbear force-pushed the robert/merge_tracer_refactor_into_pipeline_and_modules branch from 03478d2 to 96efead Compare October 29, 2025 13:05

robert-smartbear self-assigned this Oct 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sync tracer refactor into pipeline and modules #502

Sync tracer refactor into pipeline and modules #502

Uh oh!

robert-smartbear commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Sync tracer refactor into pipeline and modules #502

Are you sure you want to change the base?

Sync tracer refactor into pipeline and modules #502

Uh oh!

Conversation

robert-smartbear commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Oct 29, 2025 •

edited

Loading