Eliminate deadlock by using generate instead of setgenerate RPC

[aakselrod]

No description provided.

[davecgh]

Thanks. I'll trigger a new Travis build once btcsuite/btcd#407 has landed.

[davecgh]

@tuxcanfly Can you review this since you're far more familiar with the btcsim code than I am?

[tuxcanfly]

Sure, on it.

[tuxcanfly]

I think we can do without the goroutine since we're waiting for the blocks in the for select below anyway.

[tuxcanfly]

OK, I see that generate is blocking, unlike setgenerate so actually we could do away with the notifications handlers to wait for the miner. Let me check that.

[tuxcanfly]

Since we don't need a peer to start mining, we can probably remove the setup for adding a node to serve as the peer.

[davecgh]

What's the status of this?

[davecgh]

At the very least, it needs a rebase since it doesn't have the latest changes needed by btcrpcclient.

[tuxcanfly]

This could be better handled since generate is a blocking call as opposed to setgenerate. We were using notification handlers and goroutines to sync with the block generation which are no longer required. I've started on this in #93, let me get that prepped for review. Thanks.