-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mode presets for accuracy and performance mode to simplify enhancements settings #158
Conversation
This is a very useful feature and it's working great. It's been a almost half a year.... do you think it is possible that someone can review that, @Screwtapello? |
I like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added information in the UI seems like a good idea, too.
Thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nice improvement. For later improvement, maybe a third preset which also uses overclocking.
You are right. And I'm pretty sure performance mode will also have less visual bugs than accuracy mode overall (at least for now, see: https://arstechnica.com/gaming/2021/06/how-snes-emulators-got-a-few-pixels-from-complete-perfection/). Besides, I've played the whole library (2019-2020) with the scanline renderer and Near fixed almost every bug (some games are not compatible and switch to the cycle-based renderer). A lot of shaders don't work with the cycle-based renderer as well. So... we should write a text that is appealing, so everyones first choice is the performance mode. |
Thank you. I did overhaul my pull request. |
2021-02-22-15-56-06.mp4
Fixes: #113
When a game is loaded, you will get an information that you should reload the game in order for all changes to take effect. If no game is loaded, you will not see this, because the changes will take effect immediately. It's working really good and I think with that user will better unterstand what they have to enable for a good gaming experience.
Other than that, I'm not sure whats the best way to describe these two mode presets, but I don't think something like:
Performance mode: Maximum speed, [...]
is right, because it isn't just about speed, that's why something like "Prefer HLE" is disabled. We should come up with something appropriate, so people want to use this mode by default. You can decide what's the best way to do this.
Thanks again for your help, Screwtape. :)
Edit: