Adjustments to the mobile menu #356
Open
+37
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvellu
reviewed
Jan 28, 2025
| padding: 1rem .5rem .5rem .5rem; | ||
| border-bottom: 2px solid #ffffff; | ||
| font-size: 1rem; | ||
| } |
There was a problem hiding this comment.
Add border-radius: 0.5rem 0.5rem 0rem 0rem; to make the outer edges round
bruvellu
reviewed
Jan 28, 2025
| position: fixed; | ||
| z-index: 10; | ||
| top: -110%; | ||
| right: 2.3rem; | ||
| right: 2rem; | ||
| transition: top .3s; | ||
| } | ||
|
|
There was a problem hiding this comment.
Change the top value from #hamburger-menu[data-state="open"] (the rule below, not shown above) to 0.5rem to put the menu a bit lower (like it is floating)
bruvellu
reviewed
Jan 28, 2025
| @@ -153,7 +157,8 @@ | |||
| flex-direction: column; | |||
| align-items: flex-start; | |||
| gap: .5rem; | |||
| padding: 1.2rem .5rem .25rem .5rem; | |||
| padding: .5rem .5rem 1rem .5rem; | |||
| font-size: 1rem; | |||
| } | |||
There was a problem hiding this comment.
Add a border-radius: 0.5rem; to make the edges of the bluer list round as well
bruvellu
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjustment to menu semantics and visual adjustments to the mobile menu