Add session metadata for model name if env: BROWSERBASE
#765
Conversation
🦋 Changeset detectedLatest commit: 3e9579c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kamath
changed the title
BROWSERBASE
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added session metadata tracking for model names and custom client usage in Browserbase sessions, with corresponding test coverage and configuration updates.
- Added
modelNameandusingCustomClientmetadata inlib/index.tsfor Browserbase session creation - Added test
custom_client_metadata.test.tsto verify metadata with custom LLM clients - Updated
sessions.test.tsto verify standard model metadata tracking - Changed default model from
gpt-4otogoogle/gemini-2.0-flashinstagehand.config.ts - Added development tooling with
example-dev.tsand corresponding npm scripts
8 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
| modelName: undefined, | ||
| llmClient: new AISdkClient({ | ||
| model: google("gemini-2.0-flash"), | ||
| }), |
There was a problem hiding this comment.
logic: Setting modelName to undefined while providing an llmClient with a specific model (gemini-2.0-flash) seems inconsistent. Consider setting modelName to match the provided model or document why this is intentionally different.
There was a problem hiding this comment.
this is intentional to mock when users don't provide a modelName
| expect(session.userMetadata.stagehand).toBe("true"); | ||
| expect(session.userMetadata.modelName).toBe("NO_MODEL_DEFINED"); | ||
| expect(session.userMetadata.usingCustomClient).toBe("true"); |
There was a problem hiding this comment.
style: Values in userMetadata are stored as strings ('true', 'NO_MODEL_DEFINED'). Consider using a type-safe enum or constants for these values to prevent typos and ensure consistency.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
PR Summary
(updates since last review)
Reverted model configuration from Gemini back to GPT-4o and cleaned up development files.
- Changed model configuration in
stagehand.config.tsfromgoogle/gemini-2.0-flashback togpt-4o - Updated
sessions.test.tsto verify GPT-4o metadata instead of Gemini - Removed development files
example-dev.tsand related npm scripts - Fixed
_usingCustomClientlogic inlib/index.tsto correctly identify custom client usage
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -739,6 +744,8 @@ export class Stagehand { | |||
| this.env, | |||
| this.headless, | |||
| this.logger, | |||
| this._usingCustomClient ? "NO_MODEL_DEFINED" : this.modelName, | |||
There was a problem hiding this comment.
style: Consider using a constant for 'NO_MODEL_DEFINED' to avoid magic strings
why
Be able to show users what model config they used in the Browserbase dashboard
what changed
Just added session create metadata to send
modelNameto the Browserbase API similar tostagehand: trueon Browserbase session createtest plan
Added new evals