Skip to content

adjust log levels for act #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

seanmcguire12
Copy link
Member

why

  • these are errors that are being caught & not rethrown, but we should make sure we are setting the correct log level

what changed

  • changed log levels inside actHandler.ts and actHandlerUtils.ts to 0 (the Error level) when we catch & swallow an error

test plan

  • evals

Copy link

changeset-bot bot commented May 16, 2025

🦋 Changeset detected

Latest commit: 2a4560e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adjusts log levels in the act handler to properly categorize error messages with level 0 (Error) instead of level 1 (Info) when catching and handling errors.

  • Inconsistent error logging in lib/handlers/handlerUtils/actHandlerUtils.ts where scrollToNextChunk still uses level 1 while similar functions use level 0
  • Potentially incorrect level 0 usage for non-error message in handlePossiblePageNavigation's initial log
  • Consider keeping informational messages at level 1 and only use level 0 for actual error conditions
  • All error logging changes in lib/handlers/actHandler.ts are appropriate and consistent

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant