Allow session id to be passed through env vars #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user instantiates a browserbase session ( which would supports live view url ), this allows them to continue the session with stagehand. This is helpful for developers who want to embed the stagehand session in their product since they can now use the live view url provided by browserbase instantiation.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added support for resuming Browserbase sessions via environment variables by modifying browserbaseSessionID configuration in stagehand.config.ts to read from BROWSERBASE_SESSION_ID.
- Modified
stagehand.config.tsto readbrowserbaseSessionIDfromprocess.env.BROWSERBASE_SESSION_ID - Enables seamless session resumption for developers embedding Stagehand in their products
- Maintains backward compatibility as environment variable defaults to
undefinedif not set - Allows reuse of live view URL from existing Browserbase sessions
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -20,7 +20,7 @@ const StagehandConfig: ConstructorParams = { | |||
| apiKey: process.env.BROWSERBASE_API_KEY /* API key for authentication */, | |||
| projectId: process.env.BROWSERBASE_PROJECT_ID /* Project identifier */, | |||
| browserbaseSessionID: | |||
| undefined /* Session ID for resuming Browserbase sessions */, | |||
| process.env.BROWSERBASE_SESSION_ID /* Session ID for resuming Browserbase sessions */, | |||
| browserbaseSessionCreateParams: { | |||
| projectId: process.env.BROWSERBASE_PROJECT_ID!, | |||
There was a problem hiding this comment.
logic: Non-null assertion operator (!) used here could cause runtime errors if BROWSERBASE_PROJECT_ID is undefined
Suggested change
| projectId: process.env.BROWSERBASE_PROJECT_ID!, | |
| projectId: process.env.BROWSERBASE_PROJECT_ID, |
There was a problem hiding this comment.
also the suggestion seems wrong since BROWSERBASE_PROJECT_ID is required env var.
|
@kamath slack community links in readme seem to be broken so i am unable to learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user instantiates a browserbase session ( which would support live view url ), this allows them to continue the session with stagehand.
why
This is helpful for developers who want to embed the stagehand session in their product since they can now use the live view url provided by browserbase instantiation.
what changed
Allow session id to be passed through env vars
test plan
Backward compatible change since default will still be
undefined.