Skip to content

fix(render): escape apostrophes in concat demuxer list #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sidorovanthon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(render): escape apostrophes in concat demuxer list #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion helpers/render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,13 @@ def concat_segments(segment_paths: list[Path], out_path: Path, edit_dir: Path) -
"""Lossless concat via the concat demuxer. No re-encode."""
out_path.parent.mkdir(parents=True, exist_ok=True)
concat_list = edit_dir / "_concat.txt"
concat_list.write_text("".join(f"file '{p.resolve()}'\n" for p in segment_paths))
# Escape single quotes for the concat demuxer line format. A literal ' inside
# a single-quoted path must be written as '\'' (close quote, escaped quote,
# reopen quote); otherwise a path containing an apostrophe (e.g. a folder
# named "What I couldn't do") truncates the path and ffmpeg fails to concat.
def _concat_quote(p: Path) -> str:
return str(p.resolve()).replace("'", "'\\''")
concat_list.write_text("".join(f"file '{_concat_quote(p)}'\n" for p in segment_paths))

cmd = [
"ffmpeg", "-y",
Expand Down