Adding Script to Generate a Summary of Docker Images Used by Workflows#410
Open
Adding Script to Generate a Summary of Docker Images Used by Workflows#410
Conversation
bshifaw
commented
May 24, 2023
Contributor
Author
There was a problem hiding this comment.
Not sure if this should be kept if there is an updated python version
Collaborator
There was a problem hiding this comment.
Let's delete it when this PR gets merged.
Contributor
Author
bshifaw
commented
Sep 27, 2023
| logging.basicConfig(level=logging.INFO) | ||
|
|
||
|
|
||
| # A script to collect which dockers are in use and which latest dockers are available |
Contributor
Author
There was a problem hiding this comment.
Add to a help message
| OUT_SUMMARY_TSV = os.path.join(current_dir, "dockers.in_use.tsv") | ||
|
|
||
| if os.path.exists(OUT_SUMMARY_TSV): | ||
| os.remove(OUT_SUMMARY_TSV) |
Collaborator
There was a problem hiding this comment.
can we backup the existing one?
|
|
||
| with open(wdl_path, "r") as file_content: | ||
| content = file_content.read() | ||
| pattern = re.compile(r'.*docker:.*"') |
Contributor
Author
There was a problem hiding this comment.
Having ^ yielded no matches so removed that.
There are some instances where there is no space between : and " so changed + to *
new pattern: \s*docker:\s*"
|
|
||
| # Clear the previous line and print the progress | ||
| print(f"Progress: {progress:.2f}%\r", end="") | ||
| with open(OUT_SUMMARY_TSV, "a") as tsv_file: |
Collaborator
There was a problem hiding this comment.
write as oppsed to append?
| print(f"Progress: {progress:.2f}%\r", end="") | ||
| with open(OUT_SUMMARY_TSV, "a") as tsv_file: | ||
| # Add header | ||
| tsv_file.write(f"DOCKER_NAME\tLATEST_TAG\tUSED_TAG\tFILE_LINE\tWDL_PATH") |
Collaborator
There was a problem hiding this comment.
should need an \n after WDL_PATH.
Contributor
Author
There was a problem hiding this comment.
Not sure why but adding a \n creates an empty line between the header and the first line with the docker-wdl info.
bshifaw
commented
Sep 27, 2023
| # If the latest tag is not found locally, try to get it from remote | ||
| latest_tag = get_latest_remote_docker_tag(docker_name) if latest_tag == "NA" else latest_tag | ||
| docker_detail.append(f"{docker_name}\t{latest_tag}\t{used_tag}\t{line_num}\t{wdl_path_sum}") | ||
| else: |
added 12 commits
October 25, 2023 15:27
…rate_docker_usage_md.py to repo site by way of adding it to git_page.yml
…f output file directed to a different location from current dir
bshifaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a script that generates a TSV with a list of docker images used in our wdl files. The TSV contains