build: remove target setup from rust toolchain toml file #345
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw it when I tried locally to setup a docker aarch64 image with Rust toolchain inside to build from scratch Brioche. I wasn't understanding why the build was really slow, and why running a command with Brioche was taken more time than usual. Until I saw that my rust toolchain was cross building to x86_64 architecture.
I'm not always testing a WIP Brioche locally, most of the time, I just rely on the install script to install the latest nightly. And for the few times I had to test locally Brioche (from a custom branch, etc), I think I wasn't paying too much attention to time execution (because I was used to using Brioche in a VM, but now I'm used to use it in a native environment 🥲 thus, the time execution are not the same).
So, I think we can remove this line from
rust-toolchain.toml
file, and if Brioche is built on a non supported environment, an error message will still be printed at runtime.