Skip to content

Conversation

jaudiger
Copy link
Contributor

I saw it when I tried locally to setup a docker aarch64 image with Rust toolchain inside to build from scratch Brioche. I wasn't understanding why the build was really slow, and why running a command with Brioche was taken more time than usual. Until I saw that my rust toolchain was cross building to x86_64 architecture.

I'm not always testing a WIP Brioche locally, most of the time, I just rely on the install script to install the latest nightly. And for the few times I had to test locally Brioche (from a custom branch, etc), I think I wasn't paying too much attention to time execution (because I was used to using Brioche in a VM, but now I'm used to use it in a native environment 🥲 thus, the time execution are not the same).

So, I think we can remove this line from rust-toolchain.toml file, and if Brioche is built on a non supported environment, an error message will still be printed at runtime.

@jaudiger jaudiger requested a review from kylewlacy October 11, 2025 18:48
@jaudiger jaudiger self-assigned this Oct 11, 2025
@jaudiger jaudiger marked this pull request as draft October 11, 2025 19:00
@jaudiger jaudiger requested review from kylewlacy and removed request for kylewlacy October 11, 2025 19:00
@jaudiger jaudiger marked this pull request as ready for review October 11, 2025 19:46
Copy link
Member

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting that this took extra time when you were building... I always thought adding the target in the toolchain just told rustup to download the toolchain for that target but otherwise didn't affect the build, oops!

I think this was a relic from when brioche-runtime-utils was part of this repo (since they need to be built statically), so makes sense to remove it here 👍

@kylewlacy kylewlacy merged commit 29a4be6 into brioche-dev:main Oct 12, 2025
10 checks passed
@jaudiger jaudiger deleted the update-rust-toolchain branch October 12, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants