Conversation
Contributor
Author
|
Also I took the opportunity to uniformise all the |
…o help the dynamic linker to find shared libraries at runtime.
20a1269 to
2a964d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite for #1884. Some Node.js based recipes embeds pre-built binaries depending on the target platform. On sometimes these binaries try to access to system librairies at runtime through the dynamic linker. When we install a binary with
npmInstallGlobal()orpnpmInstallGlobal(), we wrap it withstd.addRunnablesince it requires to be run throughnode:The idea is to set the
LD_LIBRARY_PATHwithstd.addRunnablefor helping the dynamic linker to find shared libraries at runtime for these pre-built binaries. I tested it locally, and it does resolve the issue fortailwindcssandgithub_copilot_clion x86_64 architecture.