perf(utils): fast prepareValue #3370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add a performance improvements at prepare Value for non-object by skipping useless condition
charmander
requested changes
Feb 8, 2025
There was a problem hiding this comment.
I can’t reproduce those benchmark numbers with that link. Microbenchmarks can be misleading and that website seems unreliable. Like #3372, it’s fine as just cleanup anyway, though.
Comment on lines
-48
to
-51
| // null and undefined are both null for postgres | ||
| if (val == null) { | ||
| return null | ||
| } |
There was a problem hiding this comment.
I would prefer preserving this for readability and to avoid having to check typeof val === 'undefined'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a performance improvements at
prepareValuefor non-object value by skipping useless conditionOn number/string/boolean
On object/array/date/buffer
Benchmark