This repository has been archived by the owner on Dec 30, 2019. It is now read-only.
Prevent requeuing a broken client #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a client is not queryable, the pool should prevent requeuing instead of strictly enforcing errors to be propagated back to it.
| @@ -30,7 +30,7 @@ function throwOnRelease () { | |||
|
|
|||
| function release (client, err) { | |||
| client.release = throwOnRelease | |||
| if (err || this.ending) { | |||
| if (err || this.ending || !client._queryable || client._ending) { | |||
There was a problem hiding this comment.
It would be nice if the queryable state of a client is retrievable via a public method.
| @@ -30,7 +30,7 @@ function throwOnRelease () { | |||
|
|
|||
| function release (client, err) { | |||
| client.release = throwOnRelease | |||
| if (err || this.ending) { | |||
| if (err || this.ending || !client._queryable || client._ending) { | |||
There was a problem hiding this comment.
Alternatively re-adding a not queryable client could throw instead of silently re-adding.
This was referenced Aug 14, 2019
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request for comments, feedback welcome.
If a client is not queryable, the pool should prevent requeuing instead of strictly enforcing errors to be propagated back to it.
I feel this is better behaviour as otherwise a missing error passing will cause an invalid query to be constantly checked out, queries to error and client being re-added to the pool.