Skip to content
This repository has been archived by the owner on Dec 30, 2019. It is now read-only.

Fix _endCallback #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix _endCallback #106

wants to merge 2 commits into from

Conversation

fanatid
Copy link

@fanatid fanatid commented Oct 1, 2018

If Pool#end happens between client initiate connection and receiving callback with error, _endCallback will be never called.

@charmander
Copy link
Collaborator

Is it possible to include a test?

@fanatid
Copy link
Author

fanatid commented Oct 2, 2018

I tried do this, but found this is not trivial

@fanatid
Copy link
Author

fanatid commented May 30, 2019

Any updates? Tests required for each PR?

@charmander
Copy link
Collaborator

You should be able to write the test by making a net.Server that does nothing with the client it accepts but call pool.end() and close the connection. There are a few similar tests that already exist (look for createServer).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants