chore: release v1.2.5#27
Merged
Merged
Conversation
- Revert `flexMs as? KotlinLong` (always nil) back to explicit `KotlinLong(value: flexMs!)` constructor. The as? cast silently dropped flexInterval for all iOS periodic tasks. - Add KMP-BRIDGE-FROZEN marker to prevent future simplification. - Fix misleading comment: "inherently not running immediately" → clear explanation that runImmediately is forced true to satisfy KMP library.
- test: add PeriodicTrigger parameter combination matrix (8 combos, including issue_26 regression) to task_trigger_test.dart - test: add bridge_parameter_passthrough_test.dart — verifies exact map key names and value types for all trigger types - chore: add scripts/pre-commit-bridge-check.sh + install as git hook; requires 'yes' acknowledgment before committing bridge files - fix: Android logs warning when 'intervalMs' is missing from periodic trigger map instead of silently defaulting - fix: iOS logs error when 'intervalMs' is missing before returning nil
- pubignore: exclude CLAUSE.md, coverage/, test_results.txt - README: fix iOS badge (13.0+ → 14.0+), update install version to ^1.2.5 - CHANGELOG: remove duplicate --- separator and stray performance/acknowledgments block - doc: remove BUG_FIX_VERIFICATION.md from public tracking (moved to doc/internal/) - iOS workers: replace 148 bare print() calls with NativeLogger.d/w/e() - iOS HttpDownloadWorker, HttpUploadWorker: remove internal sprint/T3 planning comments - test: add periodic_trigger_reproduction_test.dart (8 cases, issue_26 regression coverage) - native_workmanager_gen: update README version to ^1.2.5, reformat CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskTrigger.periodicthat rejectedinitialDelay + runImmediately: false— a valid combination the OS handles correctly.runImmediatelyflag was being recomputed frominitialDelayinstead of using the user-provided value.Changes
Core fix (v1.2.5)
TaskTrigger.periodic: removedassertthat blockedinitialDelay + runImmediately: falseKMPSchedulerBridge: use caller-providedrunImmediatelyvalue, not recomputed valuePre-publish review (this PR)
.pubignore: excludeCLAUSE.md,coverage/,test_results.txtREADME.md: fix iOS badge13.0+→14.0+; update install snippet to^1.2.5CHANGELOG.md: remove duplicate---separator and stray performance/acknowledgments blockprint()calls withNativeLogger.d/w/e()across 9 filesHttpDownloadWorker.swift,HttpUploadWorker.swift: remove internal sprint/T3 planning commentsdoc/BUG_FIX_VERIFICATION.md: removed from public tracking (internal doc)native_workmanager_gen: update README install version to^1.2.5; reformat CHANGELOG to Keep-a-Changelog standardTests
example/integration_test/periodic_trigger_reproduction_test.dart— 8 test cases:issue_26:initialDelay + runImmediately:falseacceptedflexIntervalaccepted (covers KMP bridgeKotlinLong(value:)path)initialDelayalone acceptedrunImmediately:trueexplicit acceptedissue_26: all params combined acceptedExistingPolicy.replaceacceptedTest plan
flutter analyze— 0 issuesflutter test test/unit/ test/security/— 1127/1127 passdart pub publish --dry-run— 0 warnings after commit