release: v1.3.1 — iOS Hotfix & Quality Audit#30
Merged
vietnguyentuan2019 merged 5 commits intomainfrom May 5, 2026
Merged
Conversation
added 5 commits
May 5, 2026 23:06
PlatformGrantDelegate.requestInternal() was calling the public checkStatus() while already holding the per-permission Mutex acquired by request(). Since Kotlin's Mutex is non-reentrant, the coroutine suspended indefinitely — no permission dialog appeared and a CancellationException fired on app minimize. Fix: requestInternal() now calls checkStatusInternal() directly, matching the pattern already used by the Android implementation. Adds Issue29IosMutexDeadlockTest to regression/ to prevent recurrence.
- IosGrantDelegateTest: add Group F — 9 withTimeout-wrapped tests calling request() through the real PlatformGrantDelegate on simulator. Any future deadlock regression will fail these tests instead of hanging silently. - Bump grant-compose and grant-core-koin to v1.3.1 for hotfix release. Root cause of the test gap: IosGrantDelegateTest previously only tested checkStatus(). request() had zero coverage through the real delegate on iOS. SimulatorDetector guards on Bluetooth/Motion also masked the bug for those permissions on simulator.
github-actions
Bot
added
documentation
✅ CI Build passedBuild Status: success Artifacts
Automated comment by GitHub Actions |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+67
to
+75
| val jobs = (0 until 50).map { index -> | ||
| launch { | ||
| val grant = permissions[index % permissions.size] | ||
| val handler = GrantHandler(mockGrantManager, grant, this) | ||
| handler.request { | ||
| results.add(handler.status.value) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses critical Issue #29 (iOS Mutex Deadlock) and prepares the project for the v1.3.1 hotfix release.
Key Changes
Verification Results