ci(hooks): add shellcheck step to pre-push#36
Merged
Conversation
Lints every tracked `*.sh` plus everything under `scripts/hooks/` at `--severity=warning`, mirroring the agentnative-cli hook pattern. Skips with a one-line note when shellcheck isn't installed. Slotted between the pack-readme drift check and the prose-check stage so script hygiene gates land alongside the other lint stages. Zero existing findings on the current tree. # Conflicts: # scripts/hooks/pre-push # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # interactive rebase in progress; onto 0627021 # Last command done (1 command done): # pick da5c847 # ci(hooks): add shellcheck step to pre-push # No commands remaining. # You are currently rebasing branch 'feat/pre-push-shellcheck' on '0627021'. # # Changes to be committed: # modified: scripts/hooks/pre-push #
brettdavies
force-pushed
the
feat/pre-push-shellcheck
branch
from
da5c847 to
4e9db5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
shellcheck --severity=warningstep to the pre-push hook between the pack-README drift check and the prose-check stage. Lints every tracked*.shplus everything underscripts/hooks/at warning severity, which catches real bugs (unused vars, quoting issues, missing exits) while ignoring info/style noise. Skips with a one-line note when shellcheck isn't on PATH. Zero findings on the current tree, including the hook script itself.Mirrors the pattern landed in
agentnative-clicommita014240. The doc-comment block in the new shell-linting section was worded so lines starting with# shellcheck(which would otherwise be parsed as SC1072/SC1073 directives) are avoided.The rebase onto dev (after retargeting this PR from
main→dev) carried three small consistency edits in the same file so the resulting diff stays self-contained:Changelog
Linked check review
No check changes needed. This PR touches
scripts/hooks/pre-pushonly. No principle frontmatter, norequirements[]changes, no tier moves.Human reviewer
Reviewer: @brettdavies
AI disclosure
Hook edits, doc comments, SC1072/SC1073 collision avoidance, conflict resolution during the rebase onto dev, and this PR body were AI-drafted under direct supervision. Branch authoring, scope decision, slot placement between the pack-README drift and prose-check stages, and the base-branch retarget were Brett's calls.