feat(p2,p8,scorecard): schema subcommand, schema file, AGENTS.md frontmatter; fix badge slug + P8 filter#54
Merged
Merged
Conversation
…frontmatter; fix badge slug + P8 filter Closes four dogfood gaps surfaced by `anc check .` at v0.4.0 RC, plus the silent slug-derivation bug behind the scorecard's `badge.embed_markdown`. Changes: - `anc schema` top-level subcommand prints the embedded JSON Schema (draft 2020-12) for `anc check --output json` scorecards. Closes `p2-must-schema-print` FAIL. - `schema/scorecard.schema.json` committed at the repo root, embedded into the binary via `include_str!`. Hand-written coverage of the 0.5 shape (Scorecard plus all sub-structs: ToolInfo, AncInfo, RunInfo, PlatformInfo, TargetInfo, BadgeInfo, LevelCounts, CoverageSummary, Summary, CheckResultView) with enum casing aligned to the runtime (snake_case for status / layer / confidence). Closes `p2-should-schema-file` WARN. The schemars-derived plan that lives on `dev` (`docs/plans/2026-04-30-002-feat-scorecard-json-schema-plan.md`) remains the follow-up to derive from Rust types and drift-test at CI. - `AGENTS.md` gains YAML frontmatter naming the tool, binary, description, homepage, and repository. Closes `p8-should-bundle-exists` WARN. - `derive_tool_name` follows a four-tier fallback chain: `command_name → binary basename → manifest package name → directory basename`. The old shape returned the project directory basename, producing 404-bound badge URLs for any tool whose registered slug differed from its directory name. `anc check .` now emits `badge_url: https://anc.dev/badge/anc.svg` (returns 200), matching the site's `registry.yaml` slug. New `tests::` module in `src/main.rs` covers all four tiers of the fallback chain. - `matches_principle` gains the `(CheckGroup::P8, 8)` arm. Pre-fix, `--principle 8` silently filtered out all P8 checks because the match table predated the new principle. - README: principle count 7 → 8 with a new P8 row; JSON output sample refreshed against actual coverage totals (must 27, should 20, may 10) and snake_case casing; stale `anc.commit` field dropped from the sample to match its v0.3.0 removal; `--principle <PRINCIPLE>` doc 1-7 → 1-8 in README and `src/cli.rs`. The badge embed retains the registry slug (`anc`), which now agrees with what the binary computes. - Completions regenerated for the new `schema` subcommand. Self-check after fixes: 44 checks, 37 pass, 3 warn, 0 fail, 4 skip, 0 error (score 93%, up from 85% at the v0.4.0 RC). Remaining warnings are MAY-tier (`p8-install-all`, `p8-bundle-update`) plus the `p2-json-output` safe-probe structural limitation.
…ng into Contributing Three changes: - **Content updates for v0.4.0.** "Example Output" rewritten against the current 44-check / 93%-score self-check, including P2 schema, P6 standard names + SIGTERM, and P8 bundle results. "Three Check Layers" lists Python alongside Rust under Source. "JSON Output" intro and `tool` bullet describe the new four-tier slug fallback chain so the badge URL derivation is documented. - **Contributing reshape.** Standalone "Reporting issues" section folded into "Contributing" as a three-tier intake (signal / proposal / code) that points at the shipped `CONTRIBUTING.md` for the full breakdown. Cross-repo routing (spec repo for principle discussion, site repo for rendering bugs) preserved. - **Prose scrub.** Em-dash density brought from 20.5/1000 words to 0/1000 by recasting hyphen-clause patterns into periods, colons, or rewordings. Unslop now reports 0/100 (clean); Vale + LanguageTool report no errors. No surface-area changes. Sample JSON output and CLI reference block remain verbatim against the binary's current shape.
brettdavies
added a commit
that referenced
this pull request
May 21, 2026
…tmatter; fix badge slug + P8 filter (#54) ## Summary Closes the dogfood gaps surfaced by `anc check .` at the v0.4.0 release candidate, plus the silent slug-derivation bug behind the scorecard's badge URLs. Self-check after this branch: 44 checks, 37 pass, 3 warn, 0 fail, 0 error. Score 93% (up from 85% at the v0.4.0 RC). ## Changelog ### Added - Add `anc schema` top-level subcommand. Prints the embedded JSON Schema (draft 2020-12) describing the shape of `anc check --output json` scorecards. Closes the `p2-must-schema-print` FAIL surfaced by self-check. - Add `schema/scorecard.schema.json` committed at the repo root and embedded into the binary via `include_str!`. Hand-written coverage of the 0.5 shape (Scorecard plus ToolInfo, AncInfo, RunInfo, PlatformInfo, TargetInfo, BadgeInfo, LevelCounts, CoverageSummary, Summary, CheckResultView). Closes the `p2-should-schema-file` WARN. - Add YAML frontmatter to `AGENTS.md` naming the tool, binary, description, homepage, and repository so agent runtimes can index the bundle. Closes the `p8-should-bundle-exists` WARN. ### Changed - `derive_tool_name` now follows the four-tier fallback chain `command_name -> binary basename -> manifest package name -> directory basename`. The old shape returned the project directory basename, producing 404-bound badge URLs for any tool whose registry slug differed from its directory name. `anc check .` now emits `badge_url: https://anc.dev/badge/anc.svg` (HTTP 200, matches the site's `registry.yaml`). - `matches_principle` gains the `(CheckGroup::P8, 8)` arm. Pre-fix, `--principle 8` silently filtered out every P8 check because the match table predated the new principle. - README refreshed for v0.4.0: principle count 7 -> 8 with a P8 row, "Example Output" rewritten against the current 44-check self-check (P2 schema, P6 standard-names + SIGTERM, P8 bundle results), "Three Check Layers" lists Python alongside Rust under Source, JSON sample dropped the stale `anc.commit` field. README em-dash density scrubbed from 20.5/1000 to 0/1000. - README "Reporting issues" section folded into "Contributing" as a three-tier intake (signal / proposal / code) that points at the shipped `CONTRIBUTING.md` for the full breakdown. Cross-repo routing preserved. ### Documentation - Update `--principle <PRINCIPLE>` doc from `(1-7)` to `(1-8)` in both README and `src/cli.rs`. ## Type of Change - [x] `feat`: New feature (non-breaking change which adds functionality) ## Related Issues/Stories - Story: n/a - Issue: n/a - Architecture: Schema follow-up plan on `dev` at `docs/plans/2026-04-30-002-feat-scorecard-json-schema-plan.md` (full schemars-derive implementation; this PR ships the hand-written first cut). - Related PRs: #50, #51, #52, #53 ## Testing - [x] Unit tests added/updated - [x] Integration tests added/updated - [x] Manual testing completed - [x] All tests passing **Test Summary:** - New `src/main.rs::tests` module covers all four tiers of `derive_tool_name_inner` (command, binary, `Cargo.toml` manifest, `pyproject.toml` manifest, directory fallback). - `cargo test`: 593 passed, 2 ignored across 7 suites. - `cargo clippy --release --all-targets -- -Dwarnings`: clean. - `cargo fmt --check`: clean. - `./target/release/anc check .`: 44 checks, 37 pass, 3 warn, 0 fail, 4 skip, 0 error. Score 93%. - Live URL probe: `https://anc.dev/badge/anc.svg` returns 200. ## Files Modified **Modified:** - `AGENTS.md`, `README.md`, `src/cli.rs`, `src/main.rs`. - All five `completions/anc.*` files (regenerated for the new `schema` subcommand). **Created:** - `schema/scorecard.schema.json`. **Renamed:** - None. **Deleted:** - None. ## Breaking Changes - [x] No breaking changes ## Deployment Notes - [x] No special deployment steps required. After merge to `dev`, cherry-pick the squash commit onto `release/v0.4.0` (PR #53) and regenerate `CHANGELOG.md` before the release tag.
brettdavies
added a commit
that referenced
this pull request
May 21, 2026
brettdavies
added a commit
that referenced
this pull request
May 21, 2026
## Summary Cuts v0.4.0 by cherry-picking four PRs from `dev`: #50 (spec sync, 11 new requirement IDs across P1/P2/P4/P6/P8), #51 (binary-discovery mtime fix), #52 (prose pipeline import + un-vendor of orchestrator + doc-hygiene pass), and #54 (post-RC dogfood fixes that lift score from 85% to 93%). Adds an entire new principle (P8 Discoverable Skill Bundle), a P1 secret-handling check, the `anc schema` subcommand backing P2's runtime-discoverable-schema MUST, and a fix for the silent badge-slug bug uncovered during release polish. ## Changelog ### Added - Add P1 secret-handling check (`p1-must-secret-non-leaky-path`): scans target CLIs' `--help` for secret-bearing flag families (`--token`, `--password`, `--api-key`, `--secret`, `--auth`, `--credential`) and verifies each has either a `--*-file` companion or stdin path advertised. Vacuous Pass when no secret-bearing flag is detected. - Add P2 schema trio (`p2-must-schema-print`, `p2-should-schema-file`, `p2-should-json-aliases`): runtime-discoverable output schema via `schema` subcommand or `--schema` flag, file-export of schemas (`schema/*.json`, `*.schema.json` at repo root), and `--json` / `--jsonl` short aliases for `--output`. - Add P4 closed-set rejection check (`p4-should-enumerate-valid-set`, Rust + Python): detects clap `ValueEnum`, `PossibleValuesParser`, `value_parser!`, and Python `argparse.choices=` / `click.Choice()`. - Add P6 lifecycle and naming checks (`p6-must-sigterm`, Rust + Python; `p6-may-standard-names`): SIGTERM-handler detection across `signal_hook`, `tokio::signal::unix`, `signal.signal`, and `loop.add_signal_handler`; community-standard-verb allow-list applied to top-level subcommands. - Add P8 skill-bundle suite (`p8-should-bundle-exists`, `p8-must-bundle-install`, `p8-may-install-all`, `p8-may-bundle-update`): repo-root detection of `AGENTS.md` / `SKILL.md` with YAML frontmatter, plus help-surface probes for `skill install`, `skill install --all`, and `skill update` / `skill upgrade`. Brand-new principle in the registry. - Add `anc schema` top-level subcommand. Prints the embedded JSON Schema (draft 2020-12) describing the shape of `anc check --output json` scorecards. Closes the `p2-must-schema-print` FAIL surfaced by `anc check .` self-check. - Add `schema/scorecard.schema.json` committed at the repo root and embedded into the binary via `include_str!`. Hand-written coverage of the 0.5 shape (Scorecard plus ToolInfo, AncInfo, RunInfo, PlatformInfo, TargetInfo, BadgeInfo, LevelCounts, CoverageSummary, Summary, CheckResultView). Closes the `p2-should-schema-file` WARN. - Add YAML frontmatter to `AGENTS.md` naming the tool, binary, description, homepage, and repository so agent runtimes can index the bundle. Closes the `p8-should-bundle-exists` WARN. ### Changed - Bump CLI from 0.3.1 to 0.4.0 (MINOR; meaningful coverage growth across five principles, including a brand-new principle). - Binary discovery in `src/project.rs::discover_rust_binaries` now picks the newer of `target/release/<bin>` and `target/debug/<bin>` by mtime when both exist. Ties and metadata failures fall back to debug (matches cargo's dev-flow default). CI scenarios where only one profile is built are unchanged. - `RELEASES.md` slims to operational runbook; rationale moves to companion `RELEASES-RATIONALE.md`. Each runbook section ends with a section-pointer at the rationale. - `derive_tool_name` now follows the four-tier fallback chain `command_name -> binary basename -> manifest package name -> directory basename`. The old shape returned the project directory basename, producing 404-bound badge URLs for any tool whose registry slug differed from its directory name. `anc check .` now emits `badge_url: https://anc.dev/badge/anc.svg` (HTTP 200, matches the site's `registry.yaml`). - `matches_principle` gains the `(CheckGroup::P8, 8)` arm. Pre-fix, `--principle 8` silently filtered out every P8 check because the match table predated the new principle. - README refreshed for v0.4.0: principle count 7 -> 8 with a P8 row, "Example Output" rewritten against the current 44-check self-check (P2 schema, P6 standard-names + SIGTERM, P8 bundle results), "Three Check Layers" lists Python alongside Rust under Source, JSON sample dropped the stale `anc.commit` field. README em-dash density scrubbed from 20.5/1000 to 0/1000. - README "Reporting issues" section folded into "Contributing" as a three-tier intake (signal / proposal / code) that points at the shipped `CONTRIBUTING.md`. Cross-repo routing preserved. ### Documentation - New `PRODUCT.md` at repo root codifies linter-channel voice: second-person imperative register, three-part error shape (what failed, why, what to do), no marketing voice in CLI surface. Inherits universal rules from vendored `BRAND.md`. - New `CONTRIBUTING.md` documents the three-tier intake (signal / proposal / code), routes principle-level discussion to the spec repo, and names the dev-setup gates. - New `add-tool-to-registry` issue template for proposing CLI tools to the anc100 registry. - Document prose-scrubbing runbook in `RELEASES.md` for release-flow artifacts using Vale + LanguageTool + unslop. - `AGENTS.md` gains a "Voice and prose rules" section pointing at `PRODUCT.md` for the linter-channel register and `scripts/prose-check.sh` for the local gate. - `scripts/SYNCS.md` documents the new `sync-prose-tooling.sh` row and the consumer-owned status of `scripts/prose-check.sh`. - Update `--principle <PRINCIPLE>` doc from `(1-7)` to `(1-8)` in both README and `src/cli.rs`. ## Type of Change - [x] `feat`: New feature (non-breaking change which adds functionality) ## Related Issues/Stories - Story: n/a - Issue: n/a - Architecture: Spec sync to `agentnative-spec@v0.4.0` (vendored at `src/principles/spec/`). Scorecard JSON Schema follow-up plan lives on `dev` at `docs/plans/2026-04-30-002-feat-scorecard-json-schema-plan.md` (full schemars-derive implementation; this release ships the hand-written first cut). - Related PRs: #50, #51, #52, #54 ## Testing - [x] Unit tests added/updated - [x] Integration tests added/updated - [x] Manual testing completed - [x] All tests passing **Test Summary:** - CI green on each upstream PR (#50, #51, #52, #54) prior to dev merge. - Triple-diff verification on release branch: ship surface matches expected; no missed picks outside `docs/`; phantom-commit count consistent with prior squash-merge history. - `cargo test`: 593 passed, 2 ignored across 7 suites. New `src/main.rs::tests` module covers all four tiers of `derive_tool_name_inner` (command, binary, `Cargo.toml` manifest, `pyproject.toml` manifest, directory fallback). - `cargo clippy --release --all-targets -- -Dwarnings`: clean. - `cargo fmt --check`: clean. - `cargo run -- generate coverage-matrix --check`: exits 0 against the committed artifacts. - `bash scripts/sync-skill-fixture.sh --check`: confirms fixture matches `agentnative-site@dev` head (`4efa8ec`). - `./target/release/anc check .`: 44 checks, 37 pass, 3 warn, 0 fail, 4 skip, 0 error. Score 93%. - Live URL probe: `https://anc.dev/badge/anc.svg` returns 200. - Local pre-push hook (fmt, clippy `-Dwarnings`, test, cargo-deny, Windows compatibility check) passes. ## Files Modified **Modified:** - `Cargo.lock`, `CHANGELOG.md`, `AGENTS.md`, `CLAUDE.md`, `README.md`, `RELEASES.md`, `Cargo.toml`, `coverage/matrix.json`, `docs/coverage-matrix.md`, `scripts/SYNCS.md`. - `src/cli.rs`, `src/main.rs`, `src/principles/registry.rs`, `src/project.rs`, `src/scorecard/mod.rs`, `src/types.rs`. - `src/checks/{behavioral,project,source/{python,rust}}/mod.rs`. - `src/principles/spec/CHANGELOG.md`, `src/principles/spec/VERSION`, `src/principles/spec/principles/p1-p7*.md`. - All five `completions/anc.*` files. - `.github/ISSUE_TEMPLATE/{00-blank.yml,config.yml}`, `.gitignore`. - `tests/build_parser.rs`, `tests/dogfood.rs`. **Created:** - `BRAND.md`, `PRODUCT.md`, `CONTRIBUTING.md`, `RELEASES-RATIONALE.md`, `.vale.ini`. - `.github/ISSUE_TEMPLATE/add-tool-to-registry.yml`. - `scripts/prose-check.sh`, `scripts/sync-prose-tooling.sh`, `scripts/generate-pack-readme.mjs`, `scripts/test-prose-check.mjs`. - `schema/scorecard.schema.json`. - `src/checks/behavioral/{bundle_install,bundle_update,install_all,json_aliases,schema_print,secret_non_leaky_path,standard_names}.rs`. - `src/checks/project/{bundle_exists,schema_file}.rs`. - `src/checks/source/python/{enumerate_valid_set,sigterm}.rs`, `src/checks/source/rust/{enumerate_valid_set,sigterm}.rs`. - `src/principles/spec/principles/p8-discoverable-skill-bundle.md`. - `styles/brand/{FillerAdjectives,HedgeWords,MarketingRegister}.yml`, `styles/brand/README.md`. - `styles/config/vocabularies/{brand,cli}/{accept,reject}.txt`. **Renamed:** - None. **Deleted:** - None. ## Breaking Changes - [x] No breaking changes ## Deployment Notes - [x] No special deployment steps required. After merge: tag `v0.4.0`, push, then run `./scripts/sync-dev-after-release.sh v0.4.0` to backport release artifacts to `dev`.
brettdavies
added a commit
that referenced
this pull request
May 21, 2026
Brings dev's release-surface current with the v0.4.0 release on main: - CHANGELOG.md copied from origin/main (authoritative; release-branch regenerated it after the #54 cherry-pick). - README.md copied from origin/main. Picks up the release-branch-only edits that never went through dev: `--binary` / `--source` Quick Start examples, "Three Check Layers" isolation-flag annotations, and the new `## Scoring` section (status rubric, tier mapping, and the v0.4.0 dogfood split). Cargo.toml and Cargo.lock are already at 0.4.0 on dev via earlier cherry-picks; no bump needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the dogfood gaps surfaced by
anc check .at the v0.4.0 release candidate, plus the silent slug-derivation bugbehind the scorecard's badge URLs. Self-check after this branch: 44 checks, 37 pass, 3 warn, 0 fail, 0 error. Score 93%
(up from 85% at the v0.4.0 RC).
Changelog
Added
anc schematop-level subcommand. Prints the embedded JSON Schema (draft 2020-12) describing the shape ofanc check --output jsonscorecards. Closes thep2-must-schema-printFAIL surfaced by self-check.schema/scorecard.schema.jsoncommitted at the repo root and embedded into the binary viainclude_str!. Hand-written coverage of the 0.5 shape (Scorecard plus ToolInfo, AncInfo, RunInfo, PlatformInfo, TargetInfo, BadgeInfo, LevelCounts, CoverageSummary, Summary, CheckResultView). Closes thep2-should-schema-fileWARN.AGENTS.mdnaming the tool, binary, description, homepage, and repository so agent runtimes can index the bundle. Closes thep8-should-bundle-existsWARN.Changed
derive_tool_namenow follows the four-tier fallback chaincommand_name -> binary basename -> manifest package name -> directory basename. The old shape returned the project directory basename, producing 404-bound badge URLs for any tool whose registry slug differed from its directory name.anc check .now emitsbadge_url: https://anc.dev/badge/anc.svg(HTTP 200, matches the site'sregistry.yaml).matches_principlegains the(CheckGroup::P8, 8)arm. Pre-fix,--principle 8silently filtered out every P8 check because the match table predated the new principle.anc.commitfield. README em-dash density scrubbed from 20.5/1000 to 0/1000.CONTRIBUTING.mdfor the full breakdown. Cross-repo routing preserved.Documentation
--principle <PRINCIPLE>doc from(1-7)to(1-8)in both README andsrc/cli.rs.Type of Change
feat: New feature (non-breaking change which adds functionality)Related Issues/Stories
devatdocs/plans/2026-04-30-002-feat-scorecard-json-schema-plan.md(full schemars-derive implementation; this PR ships the hand-written first cut).Testing
Test Summary:
src/main.rs::testsmodule covers all four tiers ofderive_tool_name_inner(command, binary,Cargo.tomlmanifest,pyproject.tomlmanifest, directory fallback).cargo test: 593 passed, 2 ignored across 7 suites.cargo clippy --release --all-targets -- -Dwarnings: clean.cargo fmt --check: clean../target/release/anc check .: 44 checks, 37 pass, 3 warn, 0 fail, 4 skip, 0 error. Score 93%.https://anc.dev/badge/anc.svgreturns 200.Files Modified
Modified:
AGENTS.md,README.md,src/cli.rs,src/main.rs.completions/anc.*files (regenerated for the newschemasubcommand).Created:
schema/scorecard.schema.json.Renamed:
Deleted:
Breaking Changes
Deployment Notes
dev, cherry-pick the squash commit ontorelease/v0.4.0(PR release: v0.4.0 #53) and regenerateCHANGELOG.mdbefore the release tag.