Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent behavior for implicit and explicit selection of optional subcommands #226

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Jan 7, 2025

Default values specified in field declarations now always take precedence over default values specified in annotations. Updated tests + docs to reflect this.

cc #221

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (31b8930) to head (20e48b5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   99.82%   99.82%   -0.01%     
==========================================
  Files          28       28              
  Lines        2311     2304       -7     
==========================================
- Hits         2307     2300       -7     
  Misses          4        4              
Flag Coverage Δ
unittests 99.82% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentyi brentyi merged commit e7156a0 into main Jan 7, 2025
16 checks passed
@brentyi brentyi deleted the brent/consistent_default_subcommand branch January 7, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant