Migrate codebase to cljc #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do something different when the multimethods dispatch on object type. Because Javascript doesn't have classes, we dispatch using a keyword instead.
|
👍 |
|
@rymndhng It is great, thank you! |
|
+1 and thanks, @rymndhng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've submitted a patch here which converts the existing code into cljc. All the tests run using
lein cleantest(except for that one test where the levenshtein distance is incorrect).I think this is a cool project. If you can get back to me, that'd be great. I look forward to using this in a Clojure/Script project with Differential Syncing (also Neil Fraser's stuff).