Skip to content

Fix: Remove hardcoded Toast for network error in ContentCardsFragment #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jaypatelbond wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Remove hardcoded Toast for network error in ContentCardsFragment #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7e320c
fix: Remove hardcoded Toast for network error in ContentCardsFragment
Jaypatelbond Dec 17, 2025
afd7b39
Merge pull request #1 from Jaypatelbond/fix/remove-network-unavailabl…
Jaypatelbond Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions android-sdk-ui/src/main/java/com/braze/ui/contentcards/ContentCardsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import android.os.Parcelable
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import android.widget.Toast
import androidx.fragment.app.Fragment
import androidx.recyclerview.widget.ItemTouchHelper
import androidx.recyclerview.widget.LinearLayoutManager
Expand Down Expand Up @@ -343,13 +342,6 @@ open class ContentCardsFragment : Fragment(), SwipeRefreshLayout.OnRefreshListen
*/
protected suspend fun networkUnavailable() {
brazelog(V) { "Displaying network unavailable toast." }
context?.applicationContext?.let { applicationContext ->
Toast.makeText(
applicationContext,
applicationContext.getString(R.string.com_braze_feed_connection_error_title),
Toast.LENGTH_LONG
).show()
}
swapRecyclerViewAdapter(emptyCardsAdapter)
contentCardsSwipeLayout?.isRefreshing = false
}
Expand Down