Skip to content

style: simplify some statements for readability #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

style: simplify some statements for readability #405

wants to merge 1 commit into from

Conversation

@hamirmahal
Copy link

Closes #404

hamirmahal
hamirmahal commented Dec 1, 2024
View reviewed changes
Copy link
Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't result in any user-facing changes.

The goal of this pull request is to improve code maintainability and developer productivity.

0ex-d
0ex-d approved these changes Dec 5, 2024
View reviewed changes
Copy link

@0ex-d 0ex-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good work! @antonok-edm can take a look please

@hamirmahal
Copy link
Author

@antonok-edm are you open to merging this if I fix the merge conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@0ex-d 0ex-d 0ex-d approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some statements can be simplified for readability

2 participants

@hamirmahal @0ex-d