Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pip installation for submodules #9

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Nishit-Dua
Copy link
Contributor

Issue

Installing from git+https://github.com/braun-steven/simple-einet doesn't install the submodules "layers" and "layers.distribution" wouldn't add simple_einet.layers to the environment, upon checking the setup for package, it wasn't included in the setup file hence the sub-directories weren't bundled with the main package.

Solution

Add the submodules to the package list, if it was a .py file using setuptools we could also use setuptools.find_packages(), but for toml I believe we need to list all sub-modules to be in pip installable package

Changes

Included "simple_einet.layers", "simple_einet.layers.distributions" in the list of modules to be packaged

@braun-steven braun-steven merged commit 5c62f3f into braun-steven:main Jan 9, 2025
1 check passed
@braun-steven
Copy link
Owner

Thank you for catching this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants