Skip to content

Conversation

@bit-01
Copy link

@bit-01 bit-01 commented Feb 15, 2025

hi,
first of all i would like to say thanks for this amazing mixin which i found very helpful
i took the liberty to upgrade the code to align with the new version of sass 3.0.0 as per the docs: https://sass-lang.com/documentation/breaking-changes/import/
hope u dont mind and accept my pull request to upgrade your version as well.

upgraded the code to align with the new version of sass 3.0.0 as per the docs: https://sass-lang.com/documentation/breaking-changes/import/
@brandonmcconnell
Copy link
Owner

@bit-01 Thanks so much for submitting this PR. I’m very interested in the benefits this provides.

Could you let me know what Prettier settings you’re using. I can try to match that on my end to handle that separately to this PR’s changes can be focused on functionality changes.


Do you know if any of these changes can be backward compatible? My understanding is that some of these new functions are not compatible with the older versions I’ve been supporting thus far.

If that’s not possible, it’s not a dealbreaker. I might just phase out support for older versions and adopt the newest syntax moving forward, supporting only the latest versions.

@bit-01
Copy link
Author

bit-01 commented Feb 18, 2025

@brandonmcconnell
i am actually using the default settings for Prettier did not change anything in it.
as for the compatibility issue as i understood from the Sass 3 docs is same as u described in your comment that these changes are not backward compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants