Update openai,anthropic,google provider types#248
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d25af23938
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub size: Option<String>, | ||
| #[ts(type = "unknown")] | ||
| pub size: Option<serde_json::Value>, |
There was a problem hiding this comment.
Changing ImageGenTool.size from Option<String> to Option<serde_json::Value> removes compile-time validation and allows non-string payloads (for example numbers or objects) to serialize into OpenAI requests, which the API schema still describes as string-valued sizes. This is a type-safety regression introduced in this commit, and it can produce runtime request failures that were previously prevented by the Rust type system.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is generated I don't think it needs updates.
1 participant
Automated update of Lingua provider types.
Providers:
openai,anthropic,googleValidation
./pipelines/generate-provider-types.shfor each requested providercargo fmt --allcargo build --all-featurescargo clippy --all-targets --all-features -- -D warnings