Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability do handle MRI metadata to be saved into the BIDS Sidecar #99

Merged
merged 21 commits into from
Nov 2, 2023
Merged

Adding ability do handle MRI metadata to be saved into the BIDS Sidecar #99

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0d68351
now supports multi type for different fields
bhatiadheeraj Oct 6, 2023
01decb8
current WIP
bhatiadheeraj Oct 25, 2023
73ba2b5
solved comma issue for numeric input in array
bhatiadheeraj Oct 25, 2023
d96d85d
fixes numeric validation for required, conditional and optional fields
bhatiadheeraj Oct 30, 2023
1d7f044
removed Conditional Field
bhatiadheeraj Oct 30, 2023
921b081
removed IntendedFor field for ASL
bhatiadheeraj Oct 30, 2023
882bf63
removed log which is not required
bhatiadheeraj Oct 30, 2023
60639cd
create json_object regardless or error/warning in modalityForm
bhatiadheeraj Oct 30, 2023
7549961
[FIX] Address lingering issue
Oct 31, 2023
4ea1428
[ENH] Provide warning to user to check metadata
Oct 31, 2023
b02926b
minor edits
Oct 31, 2023
a1eb6b7
added ability to parse conditionals with array EX required if is in …
bhatiadheeraj Oct 31, 2023
9a25527
[FIX] slightly modifications to asl.yaml
Oct 31, 2023
5394780
added background color to cols
bhatiadheeraj Nov 1, 2023
4ce2f21
Merge branch 'perf_asl_multi_type' of github.com:brainlife/ezbids int…
bhatiadheeraj Nov 1, 2023
f7c9b97
code cleanup
bhatiadheeraj Nov 1, 2023
760d6e7
background color Change
bhatiadheeraj Nov 1, 2023
b4c8d98
[FIX] Add IntendedFor metadata into m0scan json
Nov 2, 2023
cd4a500
validation to differentiate between number and array-type Number value
bhatiadheeraj Nov 2, 2023
e483d1e
Merge branch 'perf_asl_multi_type' of github.com:brainlife/ezbids int…
bhatiadheeraj Nov 2, 2023
8b9f42b
removed log statements
bhatiadheeraj Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ui/src/SeriesPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,11 @@ export default defineComponent({
})
}
}

// Alert users to check relevant metadata ("Edit Metadata" button for any perf sequences)
if (s.type.startsWith("perf")) {
s.validationWarnings.push("Please check to ensure that all necessary metadata is provided, by clicking on the 'Edit Metadata' button below")
}
},

isValid(cb: (v?: string)=>void) {
Expand Down
28 changes: 26 additions & 2 deletions ui/src/assets/schema/rules/sidecars/asl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,27 @@ MRIASLCommonMetadataFields:
LabelingLocationDescription: recommended
LookLocker: optional
LabelingEfficiency: optional
LabelingDuration:
level: optional
level_addendum: required if `ArterialSpinLabelingType` is in [`PCASL`,`CASL`]
LabelingPulseAverageGradient:
level: optional
level_addendum: recommended if `ArterialSpinLabelingType` is in [`PCASL`,`CASL`]
LabelingPulseMaximumGradient:
level: optional
level_addendum: recommended if `ArterialSpinLabelingType` is in [`PCASL`,`CASL`]
LabelingPulseAverageB1:
level: optional
level_addendum: recommended if `ArterialSpinLabelingType` is in [`PCASL`,`CASL`]
LabelingPulseDuration:
level: optional
level_addendum: required if `ArterialSpinLabelingType` is in [`PCASL`,`CASL`]
LabelingPulseFlipAngle:
level: optional
level_addendum: recommended if `ArterialSpinLabelingType` is in [`PCASL`,`CASL`]
LabelingPulseInterval:
level: optional
level_addendum: recommended if `ArterialSpinLabelingType` is in [`PCASL`,`CASL`]

MRIASLCommonMetadataFieldsM0TypeRec:
selectors:
Expand Down Expand Up @@ -120,7 +141,10 @@ MRIASLPcaslSpecific:
fields:
PCASLType:
level: recommended
level_addendum: if `ArterialSpinLabelingType` is `"PCASL"`
level_addendum: recommended if `ArterialSpinLabelingType` is `PCASL`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCASLType is already recommended, does the addendum change anything?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlevitas

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The level_addendum specifies conditions where the metadata might become required (or recommended), based on other metadata values

LabelingDuration:
level: optional
level_addendum: required if `ArterialSpinLabelingType` is `PCASL`

MRIASLCaslSpecific:
selectors:
Expand All @@ -130,7 +154,7 @@ MRIASLCaslSpecific:
fields:
CASLType:
level: recommended
level_addendum: if `ArterialSpinLabelingType` is `"CASL"`
level_addendum: recommended if `ArterialSpinLabelingType` is `"CASL"`

MRIASLPaslSpecific:
selectors:
Expand Down
Loading