Skip to content

Fix off by one error in test #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamltyson merged 4 commits into from
Dec 3, 2025
Merged

Fix off by one error in test #263

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
711b807
Fix off by one error in test
IgorTatarnikov Dec 1, 2025
07e1e43
Fetch midpoint based on atlas not the ar projection
IgorTatarnikov Dec 1, 2025
c573b28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 1, 2025
31c2c0a
Update setup-micromamba version
IgorTatarnikov Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions tests/test_brainreg_napari.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ def test_workflow(make_napari_viewer, tmp_path):
assert isinstance(boundaries, napari.layers.Image)


@pytest.mark.xfail(
reason="See https://github.com/brainglobe/cellfinder/issues/443",
raises=AssertionError,
)
def test_orientation_check(
make_napari_viewer, tmp_path, atlas_choice="allen_mouse_50um"
):
Expand Down Expand Up @@ -130,9 +126,10 @@ def test_orientation_check(
ar_projection = viewer.layers["Ref. proj. 1"].data
import numpy as np

assert ar_projection.shape[1] // 2 == 114
assert np.all(ar_projection[:, 114] == 0)
assert not np.all(ar_projection[:, 115] == 0)
midpoint = atlas.shape[2] // 2
assert ar_projection.shape[1] // 2 == midpoint
assert np.all(ar_projection[:, midpoint - 1] == 0)
assert not np.all(ar_projection[:, midpoint] == 0)


def run_and_check_orientation_check(widget, viewer, brain_layer, atlas):
Expand Down
Loading