Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Galea v4 emulator to control sampling rate #681

Merged
merged 9 commits into from
Dec 16, 2023

Conversation

retiutut
Copy link
Member

No description provided.

@retiutut retiutut changed the title Update galea v4 emulator to control sampling rate Update gGalea v4 emulator to control sampling rate Oct 19, 2023
@retiutut retiutut changed the title Update gGalea v4 emulator to control sampling rate Update Galea v4 emulator to control sampling rate Oct 19, 2023
@Andrey1994
Copy link
Member

part about adding new command is fine but I dont get the motivation for debug messages and all these calculations, seems like it doesnt change anything in terms of sampling rate

@retiutut
Copy link
Member Author

part about adding new command is fine but I dont get the motivation for debug messages and all these calculations, seems like it doesnt change anything in terms of sampling rate

It works as expected on the receiving end.

@retiutut
Copy link
Member Author

@Andrey1994 @philippitts Can we review and merge? This has many important additions.

Signed-off-by: Andrey Parfenov <[email protected]>
@Andrey1994
Copy link
Member

I've fixed failed alpine test and removed some logic which made it too complicated for simple emulator. The proper tracking and emulation of sampling rate behaviour would require another approach and more refactoring. And after all sampling rate matching is not a requirement for functional high level model, keeped logic for channel settings and notifications for sampling rate commands

@Andrey1994 Andrey1994 merged commit cc833cf into brainflow-dev:master Dec 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants