-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Galea v4 emulator to control sampling rate #681
Update Galea v4 emulator to control sampling rate #681
Conversation
part about adding new command is fine but I dont get the motivation for debug messages and all these calculations, seems like it doesnt change anything in terms of sampling rate |
It works as expected on the receiving end. |
@Andrey1994 @philippitts Can we review and merge? This has many important additions. |
Signed-off-by: Andrey Parfenov <[email protected]>
Signed-off-by: Andrey Parfenov <[email protected]>
I've fixed failed alpine test and removed some logic which made it too complicated for simple emulator. The proper tracking and emulation of sampling rate behaviour would require another approach and more refactoring. And after all sampling rate matching is not a requirement for functional high level model, keeped logic for channel settings and notifications for sampling rate commands |
No description provided.